From 0f9970722f0223428398ee060c14d76c8bd81d64 Mon Sep 17 00:00:00 2001
From: Mia Winter <mia@miawinter.de>
Date: Sun, 17 Mar 2024 13:46:16 +0100
Subject: [PATCH] Improved SEO through better page titles (this mostly affects
 google)

---
 Wave/Components/Pages/Admin.razor                | 6 +++---
 Wave/Components/Pages/ArticleDeleteConfirm.razor | 6 +++---
 Wave/Components/Pages/ArticleEditor.razor        | 6 +++---
 Wave/Components/Pages/ArticleView.razor          | 6 +++---
 Wave/Components/Pages/CategoryView.razor         | 9 ++++++---
 Wave/Components/Pages/Deleted.razor              | 6 +++---
 Wave/Components/Pages/Drafts.razor               | 4 ++++
 Wave/Components/Pages/EmailEdit.razor            | 6 +++---
 Wave/Components/Pages/EmailSignup.razor          | 6 +++---
 Wave/Components/Pages/Error.razor                | 6 ++++--
 Wave/Components/Pages/Future.razor               | 5 +++++
 Wave/Components/Pages/Home.razor                 | 2 +-
 Wave/Components/Pages/ManageApi.razor            | 6 +++---
 Wave/Components/Pages/ManageCategories.razor     | 6 +++---
 Wave/Components/Pages/ManageUsers.razor          | 6 +++---
 Wave/Components/Pages/Newsletter.razor           | 6 +++---
 Wave/Components/Pages/Review.razor               | 4 ++++
 Wave/Components/Pages/UserView.razor             | 9 ++++++---
 Wave/Program.cs                                  | 3 +--
 19 files changed, 64 insertions(+), 44 deletions(-)

diff --git a/Wave/Components/Pages/Admin.razor b/Wave/Components/Pages/Admin.razor
index f04fa32..bd18b6f 100644
--- a/Wave/Components/Pages/Admin.razor
+++ b/Wave/Components/Pages/Admin.razor
@@ -17,7 +17,7 @@
 @inject IStringLocalizer<Admin> Localizer
 @inject IDistributedCache WaveDistributedCache
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <StatusMessage Message="@Message" />
 
@@ -40,8 +40,8 @@
 </EditForm>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+    [CascadingParameter(Name = "TitlePostfix")]
+    private string TitlePostfix { get; set; } = default!;
 
     [CascadingParameter]
     private HttpContext HttpContext { get; set; } = default!;
diff --git a/Wave/Components/Pages/ArticleDeleteConfirm.razor b/Wave/Components/Pages/ArticleDeleteConfirm.razor
index c2b9f25..d639a48 100644
--- a/Wave/Components/Pages/ArticleDeleteConfirm.razor
+++ b/Wave/Components/Pages/ArticleDeleteConfirm.razor
@@ -9,7 +9,7 @@
 @inject ILogger<ArticleDeleteConfirm> Logger
 @inject IStringLocalizer<ArticleView> Localizer
 
-<PageTitle>@(TitlePrefix + (Article is not null ? Localizer["Delete_Title"] : Localizer["NotFound_Title"]))</PageTitle>
+<PageTitle>@((Article is not null ? Localizer["Delete_Title"] : Localizer["NotFound_Title"]) + TitlePostfix)</PageTitle>
 
 @if (Article is not null) {
 	<BoardComponent CenterContent="true">
@@ -34,8 +34,8 @@
 
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	[Parameter]
 	public Guid Id { get; set; }
diff --git a/Wave/Components/Pages/ArticleEditor.razor b/Wave/Components/Pages/ArticleEditor.razor
index 6bf3372..7d3f508 100644
--- a/Wave/Components/Pages/ArticleEditor.razor
+++ b/Wave/Components/Pages/ArticleEditor.razor
@@ -10,7 +10,7 @@
 @inject UserManager<ApplicationUser> UserManager
 @inject IStringLocalizer<ArticleEditor> Localizer
 
-<PageTitle>@(TitlePrefix + Localizer["EditorTitle"])</PageTitle>
+<PageTitle>@(Localizer["EditorTitle"] + TitlePostfix)</PageTitle>
 
 @if (User is null) {
 	<h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["EditorTitle"]</h1>
@@ -33,8 +33,8 @@
 
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	[CascadingParameter]
 	private Task<AuthenticationState>? AuthenticationState { get; set; }
 
diff --git a/Wave/Components/Pages/ArticleView.razor b/Wave/Components/Pages/ArticleView.razor
index 32501b0..9cc011b 100644
--- a/Wave/Components/Pages/ArticleView.razor
+++ b/Wave/Components/Pages/ArticleView.razor
@@ -22,7 +22,7 @@
 @inject EmailFactory Email
 @inject IEmailService EmailService
 
-<PageTitle>@(TitlePrefix + (Article?.Title ?? Localizer["NotFound_Title"]))</PageTitle>
+<PageTitle>@((Article?.Title ?? Localizer["NotFound_Title"]) + TitlePostfix)</PageTitle>
 
 @if (Article is not null) {
 	<HeadContent>
@@ -105,8 +105,8 @@
 </ErrorBoundary>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	#region Route Parameters
 	
diff --git a/Wave/Components/Pages/CategoryView.razor b/Wave/Components/Pages/CategoryView.razor
index 3bb4d20..d150ab8 100644
--- a/Wave/Components/Pages/CategoryView.razor
+++ b/Wave/Components/Pages/CategoryView.razor
@@ -14,9 +14,12 @@
 		<link rel="alternate" type="application/rss+xml" title="RSS Feed on @Customizations.Value.AppName | @Category.Name" href="/rss/rss.xml?category=@WebUtility.UrlEncode(Category.Name)">
 		<link rel="alternate" type="application/atom+xml" title="Atom RSS Feed on @Customizations.Value.AppName | @Category.Name" href="/rss/atom.xml?category=@WebUtility.UrlEncode(Category.Name)">
 	}
+	@if (Category is null) {
+		<meta name="robots" content="noindex">
+	}
 </HeadContent>
 
-<PageTitle>@(TitlePrefix + Localizer["Title"] + " | " + (Category?.Name ?? "Not Found"))</PageTitle>
+<PageTitle>@($"{Category?.Name ?? "Not Found"} {TitlePostfix}")</PageTitle>
 
 @if (Category is null) {
 	<h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["NotFound_Title"]</h1>
@@ -29,8 +32,8 @@
 }
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	[Parameter]
 	public string CategoryName { get; set; } = string.Empty;
diff --git a/Wave/Components/Pages/Deleted.razor b/Wave/Components/Pages/Deleted.razor
index 9a65975..1ac524c 100644
--- a/Wave/Components/Pages/Deleted.razor
+++ b/Wave/Components/Pages/Deleted.razor
@@ -8,7 +8,7 @@
 @inject IDbContextFactory<ApplicationDbContext> ContextFactory
 @inject IStringLocalizer<Deleted> Localizer
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 
@@ -23,8 +23,8 @@
 </ArticleCardList>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	private List<Article> Articles { get; } = [];
 
diff --git a/Wave/Components/Pages/Drafts.razor b/Wave/Components/Pages/Drafts.razor
index 5927f0d..056fd27 100644
--- a/Wave/Components/Pages/Drafts.razor
+++ b/Wave/Components/Pages/Drafts.razor
@@ -8,10 +8,14 @@
 @inject UserManager<ApplicationUser> UserManager
 @inject IStringLocalizer<Drafts> Localizer
 
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
+
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 <ArticleCardList Articles="Articles" />
 
 @code {
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	[CascadingParameter]
 	private HttpContext HttpContext { get; set; } = default!;
 	
diff --git a/Wave/Components/Pages/EmailEdit.razor b/Wave/Components/Pages/EmailEdit.razor
index c00039c..a573027 100644
--- a/Wave/Components/Pages/EmailEdit.razor
+++ b/Wave/Components/Pages/EmailEdit.razor
@@ -16,7 +16,7 @@
 	<meta name="robots" content="noindex,nofollow">
 </HeadContent>
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <BoardComponent CenterContent="true">
 	<BoardCardComponent Heading="@Localizer["Title"]">
@@ -33,8 +33,8 @@
 </BoardComponent>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	
 	[Parameter, SupplyParameterFromQuery(Name = "user")]
 	public string? Id { get; set; }
diff --git a/Wave/Components/Pages/EmailSignup.razor b/Wave/Components/Pages/EmailSignup.razor
index ee96957..e169392 100644
--- a/Wave/Components/Pages/EmailSignup.razor
+++ b/Wave/Components/Pages/EmailSignup.razor
@@ -22,7 +22,7 @@
 	<link rel="canonical" href="@(new UriBuilder(Navigation.BaseUri) { Scheme = "https", Port = -1, Path = "/email/subscribe" }.Uri.AbsoluteUri)" />
 </HeadContent>
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <BoardComponent CenterContent="true">
 	<BoardCardComponent Heading="@Localizer["Title"]">
@@ -44,8 +44,8 @@
 </BoardComponent>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	[SupplyParameterFromForm(FormName = "email-signup")]
 	private InputModel Model { get; set; } = new();
 
diff --git a/Wave/Components/Pages/Error.razor b/Wave/Components/Pages/Error.razor
index a6d3b61..f56613a 100644
--- a/Wave/Components/Pages/Error.razor
+++ b/Wave/Components/Pages/Error.razor
@@ -3,7 +3,7 @@
 
 @inject IStringLocalizer<Error> Localizer
 
-<PageTitle>@Localizer["Title"]</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <h1 class="text-3xl lg:text-5xl font-light text-primary">@Localizer["Title"]</h1>
 
@@ -15,7 +15,9 @@
     </p>
 }
 
-@code{
+@code {
+    [CascadingParameter(Name = "TitlePostfix")]
+    private string TitlePostfix { get; set; } = default!;
     [CascadingParameter]
     private HttpContext? HttpContext { get; set; }
 
diff --git a/Wave/Components/Pages/Future.razor b/Wave/Components/Pages/Future.razor
index 28a64d4..117ad20 100644
--- a/Wave/Components/Pages/Future.razor
+++ b/Wave/Components/Pages/Future.razor
@@ -6,10 +6,15 @@
 @inject IDbContextFactory<ApplicationDbContext> ContextFactory
 @inject IStringLocalizer<Future> Localizer
 
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
+
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 <ArticleCardList Articles="Articles" />
 
 @code {
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
+
     private List<Article> Articles { get; } = [];
 
     protected override async Task OnInitializedAsync() {
diff --git a/Wave/Components/Pages/Home.razor b/Wave/Components/Pages/Home.razor
index 73483dd..849bbb9 100644
--- a/Wave/Components/Pages/Home.razor
+++ b/Wave/Components/Pages/Home.razor
@@ -40,7 +40,7 @@
 	}
 </HeadContent>
 
-<PageTitle>@(TitlePrefix[..^3])</PageTitle>
+<PageTitle>@(Customizations.Value.AppName ?? "Wave")</PageTitle>
 
 <div class="grid grid-cols-1 sm:grid-cols-2 xl:grid-cols-4 xl:grid-rows-4 gap-4">
 	<div class="sm:col-span-2 flex flex-col">
diff --git a/Wave/Components/Pages/ManageApi.razor b/Wave/Components/Pages/ManageApi.razor
index 45386db..52c6b59 100644
--- a/Wave/Components/Pages/ManageApi.razor
+++ b/Wave/Components/Pages/ManageApi.razor
@@ -12,7 +12,7 @@
 @inject IMessageDisplay Message
 @inject IStringLocalizer<ManageApi> Localizer
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 
@@ -81,8 +81,8 @@
 </section>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	[SupplyParameterFromForm(FormName = "NewApiKey")]
 	private InputModel Model { get; set; } = new();
 
diff --git a/Wave/Components/Pages/ManageCategories.razor b/Wave/Components/Pages/ManageCategories.razor
index 9bec96f..50cdb9d 100644
--- a/Wave/Components/Pages/ManageCategories.razor
+++ b/Wave/Components/Pages/ManageCategories.razor
@@ -11,7 +11,7 @@
 @inject IStringLocalizer<ManageCategories> Localizer
 @inject IMessageDisplay Message
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <ModalComponent Id="@ModalId">
 	<ChildContent>
@@ -67,8 +67,8 @@ bg-error text-error-content
 </ul>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	private InputModel Model { get; set; } = new();
 	private List<Category> Categories { get; } = new();
diff --git a/Wave/Components/Pages/ManageUsers.razor b/Wave/Components/Pages/ManageUsers.razor
index a109daa..0727aeb 100644
--- a/Wave/Components/Pages/ManageUsers.razor
+++ b/Wave/Components/Pages/ManageUsers.razor
@@ -13,7 +13,7 @@
 @inject IStringLocalizer<ManageUsers> Localizer
 @inject IMessageDisplay Toast
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1> 
 
@@ -57,8 +57,8 @@
 </section>
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+    [CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
     private string ModalId { get; } = "UserDialog";
 
 	[CascadingParameter]
diff --git a/Wave/Components/Pages/Newsletter.razor b/Wave/Components/Pages/Newsletter.razor
index bf3d618..c69022f 100644
--- a/Wave/Components/Pages/Newsletter.razor
+++ b/Wave/Components/Pages/Newsletter.razor
@@ -8,7 +8,7 @@
 @inject IDbContextFactory<ApplicationDbContext> ContextFactory
 @inject IOptions<Features> Features
 
-<PageTitle>@(TitlePrefix + Localizer["Title"])</PageTitle>
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
 
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 
@@ -56,8 +56,8 @@
 
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 
 	private IReadOnlyList<EmailNewsletter> Newsletters { get; set; } = [];
 	private int SubscribersTotal { get; set; }
diff --git a/Wave/Components/Pages/Review.razor b/Wave/Components/Pages/Review.razor
index 1b1cd59..e09a451 100644
--- a/Wave/Components/Pages/Review.razor
+++ b/Wave/Components/Pages/Review.razor
@@ -6,10 +6,14 @@
 @inject IDbContextFactory<ApplicationDbContext> ContextFactory
 @inject IStringLocalizer<Review> Localizer
 
+<PageTitle>@(Localizer["Title"] + TitlePostfix)</PageTitle>
+
 <h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["Title"]</h1>
 <ArticleCardList Articles="Articles" />
 
 @code {
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	private List<Article> Articles { get; } = [];
 
 	protected override async Task OnInitializedAsync() {
diff --git a/Wave/Components/Pages/UserView.razor b/Wave/Components/Pages/UserView.razor
index e354ef8..6e5496d 100644
--- a/Wave/Components/Pages/UserView.razor
+++ b/Wave/Components/Pages/UserView.razor
@@ -15,9 +15,12 @@
 		<link rel="alternate" type="application/rss+xml" title="RSS Feed on @Customizations.Value.AppName | User @User.FullName" href="/rss/rss.xml?author=@User.Id">
 		<link rel="alternate" type="application/atom+xml" title="Atom RSS Feed on @Customizations.Value.AppName | User @User.FullName" href="/rss/atom.xml?author=@User.Id">
 	}
+	@if (User is null) {
+		<meta name="robots" content="noindex">
+	}
 </HeadContent>
 
-<PageTitle>@(TitlePrefix + @Localizer["Title"] + " | " + (User?.FullName ?? Localizer["NotFound_Title"]))</PageTitle>
+<PageTitle>@($"{(User?.FullName ?? Localizer["NotFound_Title"])} {TitlePostfix}")</PageTitle>
 
 @if (User is null) {
 	<h1 class="text-3xl lg:text-5xl font-light mb-6 text-primary">@Localizer["NotFound_Title"]</h1>
@@ -62,8 +65,8 @@
 }
 
 @code {
-	[CascadingParameter(Name = "TitlePrefix")]
-	private string TitlePrefix { get; set; } = default!;
+	[CascadingParameter(Name = "TitlePostfix")]
+	private string TitlePostfix { get; set; } = default!;
 	[CascadingParameter]
 	public required HttpContext HttpContext { get; set; }
 
diff --git a/Wave/Program.cs b/Wave/Program.cs
index 7f9cc7c..a530075 100644
--- a/Wave/Program.cs
+++ b/Wave/Program.cs
@@ -173,8 +173,7 @@
 
 builder.Services.Configure<Features>(builder.Configuration.GetSection(nameof(Features)));
 builder.Services.Configure<Customization>(builder.Configuration.GetSection(nameof(Customization)));
-builder.Services.AddCascadingValue("TitlePrefix",
-	sf => (sf.GetService<IOptions<Customization>>()?.Value.AppName ?? "Wave") + " - ");
+builder.Services.AddCascadingValue("TitlePostfix", sf => " | " + (sf.GetService<IOptions<Customization>>()?.Value.AppName ?? "Wave"));
 
 var emailConfig = builder.Configuration.GetSection("Email").Get<EmailConfiguration>();
 builder.Services.Configure<EmailConfiguration>(builder.Configuration.GetSection("Email"));