winter-software/Wave
winter-software/Wave
1
0
Fork 0
Code Issues Wiki Activity

Improved Article slug generation

Browse source
This commit is contained in:
Mia Rose Winter 2024-04-30 15:47:42 +02:00
parent 2c44951e13
commit 292433d200
Signed by: miawinter
GPG key ID: 4B6F6A83178F595E
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Wave/Data/Article.cs
View file

@ -46,20 +46,26 @@ public class Article : ISoftDelete {
public IList<Category> Categories { get; } = []; public IList<Category> Categories { get; } = [];
public IList<ArticleImage> Images { get; } = []; public IList<ArticleImage> Images { get; } = [];
public void UpdateSlug(string? potentialNewSlug) { public void UpdateSlug(string? potentialNewSlug = null) {
if (!string.IsNullOrWhiteSpace(potentialNewSlug) && Uri.IsWellFormedUriString(potentialNewSlug, UriKind.Relative)) {
Slug = potentialNewSlug;
return;
}
if (string.IsNullOrWhiteSpace(potentialNewSlug) && !string.IsNullOrWhiteSpace(Slug)) return; if (string.IsNullOrWhiteSpace(potentialNewSlug) && !string.IsNullOrWhiteSpace(Slug)) return;
string baseSlug = potentialNewSlug ?? Title; string baseSlug = potentialNewSlug ?? Title;
baseSlug = baseSlug.ToLowerInvariant()[..Math.Min(64, baseSlug.Length)]; baseSlug = baseSlug.ToLowerInvariant()[..Math.Min(64, baseSlug.Length)];
string slug = Uri.EscapeDataString(baseSlug).Replace("-", "+").Replace("%20", "-"); string slug = Uri.EscapeDataString(baseSlug).Replace("-", "+").Replace("%20", "-");
// if our escaping increases the slug length, there is a chance it ends with an escape // if our escaping increases the slug length, there is a chance it ends with an escape
// character, so if this overshoot is not divisible by 3, then we risk cutting of the // character, so if this overshoot is not divisible by 3, then we risk cutting of the
// escape character, so we need to remove it in it's entirely if that's the case // escape character, so we need to remove it in it's entirely if that's the case
int escapeTrimOvershoot = Math.Max(0, 3 - (slug.Length - baseSlug.Length) % 3); int escapeTrimOvershoot = 0;
if (slug.Length > 64) escapeTrimOvershoot = slug[62..64].Contains('%') ? 1 : 0;
// if the slug already fits 64 character, there will be no cutoff in the next operation anyway, // if the slug already fits 64 character, there will be no cutoff in the next operation anyway,
// so we don't need to fix what is described in the previous comment // so we don't need to fix what is described in the previous comment
if (slug.Length <= 64) escapeTrimOvershoot = 0;
Slug = slug[..Math.Min(slug.Length, 64 - escapeTrimOvershoot)]; Slug = slug[..Math.Min(slug.Length, 64 - escapeTrimOvershoot)];
if (Slug.EndsWith("%")) Slug = Slug[..^1];
} }
public void UpdateBody() { public void UpdateBody() {